Fix dependencies and tests#13
Conversation
+ Upgrade phpunit and fix tests + Fix passing null to strpos triggering warning on new php + Raise doctrine/cache to v1.4.1 since void cache was not in 1.4
+ Remove travis
|
@nguyenk This pr should make releasing v2 possible |
|
@moufmouf This one is similar to other prs: |
homersimpsons
left a comment
homersimpsons
left a comment
There was a problem hiding this comment.
Thank you for your work on this ! Just a small concern about a test and then it is ready to merge.
Co-authored-by: homersimpsons <guillaume.alabre@gmail.com>
Applied the suggestion, the assertion message is different than expectedException message indeed |
|
Thank you for your contribution ! I saw you had some open Pull Request targeting your own forks. Maybe those are not ready yet, or the target is not correct: |
Those are for testing the ci pipeline, i'll create more pr's in original repos soon |
|
Can u do a release of v2 as well, or something else needs merging |
I did a pre-release:
If it is stable, I can do a real release. I do not think we have to merge anything else. |
2 participants
Follow up of 0ccb1a2
To support dbal v3 fully i bumped up the dependencies and php versions
Also added github ci and removed travis